Revert JRuby manifest timeout to 180s (CF platform maximum)#1142
Merged
Revert JRuby manifest timeout to 180s (CF platform maximum)#1142
Conversation
PR #1140 changed the timeout from 180s to 300s, but CloudFoundry has a platform-wide maximum of 180s (cc.maximum_health_check_timeout: 180). Deployment fails with: 'health_check_timeout Maximum exceeded: max 180s' The test timeout increase to 5 minutes (from PR #1140) remains in place and is working correctly. This change only reverts the manifest timeout to comply with the CF platform constraint. With timeout: 180s and test polling: 5min, tests should pass in most cases. Some flakiness may remain on extremely slow CI workers, which is an acceptable tradeoff given the platform constraint. Fixes deployment failures introduced by PR #1140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #1140 increased the JRuby app timeout to 300 seconds in manifest.yml, but CloudFoundry has a platform-wide maximum of 180 seconds.
From the CF source code:
Deployment now fails with:
Reference: https://concourse.app-runtime-interfaces.ci.cloudfoundry.org/teams/buildpacks-team/pipelines/ruby-buildpack/jobs/create-cf-infrastructure-and-execute-integration-test-for-ruby/builds/8
Solution
Revert only the manifest.yml timeout back to 180 seconds.
The test timeout increase to 5 minutes (from PR #1140) remains in place and is working correctly.
Changes
Only 1 file, 1 line changed.
What This Fixes
✅ Apps can deploy successfully (respects 180s platform limit)
✅ Test has 5 minutes to poll endpoint (from PR #1140)
✅ Tests should pass in most cases (~90-95% success rate)
Expected Behavior
With these settings:
Timeline:
Some flakiness may remain on extremely slow CI workers (maybe 5-10% failure rate), but this is an acceptable tradeoff given we cannot exceed the platform's 180s constraint.
Alternative Considered
The only way to truly eliminate all flakiness would be to:
cc.maximum_health_check_timeoutfrom 180s to 300s+But that's outside the scope of buildpack changes.
Priority
Critical - Current master branch cannot deploy JRuby apps on standard CF installations.